search

ef4 / ember-elsewhere

Render elsewhere in the DOM, with nice composition, animation, etc. Based on 100% public API.
MIT License
184 stars 25 forks source link

Error on canary: `{{#with}}` is deprecated #45

Open gitKrystan opened 3 years ago

gitKrystan commented 3 years ago

Hello there!

We are running into this deprecation on our canary builds:

Template Compiler Error (broccoli-persistent-filter:TemplateCompiler) in ember-elsewhere/templates/components/from-elsewhere.hbs

`{{#with}}` is deprecated. If you always want the block to render, replace `{{#with}}` with `{{#let}}`. If you want to conditionally render the block, use `{{#let}}` together with `{{#if}} instead. ('ember-elsewhere/templates/components/from-elsewhere.hbs' @ L6:C6)

Looks like it comes from this template:

https://github.com/ef4/ember-elsewhere/blob/dadfa69ab5be259ea83d6bed1831bdb7989691cb/addon/templates/components/from-elsewhere.hbs#L6-L8

Happy to make a PR if you'd like. I don't know enough about ember-elsewhere to know if I should make the block render conditionally or if just replacing {{#with}} with {{#let}} would be appropriate. Thoughts?

chancancode commented 3 years ago

The deprecation for "property fallback" (i.e. use this.active.lastObject.component instead of active.lastObject.component) is about to land on canary as well

cah-brian-gantzler commented 3 years ago

this was fixed with https://github.com/ef4/ember-elsewhere/pull/50