ef4 / ember-elsewhere

Render elsewhere in the DOM, with nice composition, animation, etc. Based on 100% public API.
MIT License
184 stars 25 forks source link

Address hasBlock deprecation: update to has-block #46

Closed kpfefferle closed 3 years ago

kpfefferle commented 3 years ago

As of Ember 3.26,hasBlock has been deprecated in favor of (has-block). This updates the addon's two uses of hasBlock accordingly.

RFC: https://github.com/emberjs/rfcs/pull/689 PR: https://github.com/emberjs/ember.js/pull/19374 Deprecation Guide: https://deprecations.emberjs.com/v3.x/#toc_has-block-and-has-block-params

bgantzler commented 3 years ago

Hey Kevin.

Didnt see this PR was already made since there wasnt an issue created :)

Will close mine since its the same code change as yours. Not sure whats up with the ember-release failure though

references https://github.com/ef4/ember-elsewhere/issues/47

ef4 commented 3 years ago

Thanks, released in 1.2.1.