search

efabless / caravel-gf180mcu

This repository is the GF180MCU port of Caravel. For more information about Caravel, see the original repo at https://github.com/efabless/caravel.
Apache License 2.0
8 stars 8 forks source link

caravel.v instantiates chip_io with signals connected directly to power pins #59

Closed RTimothyEdwards closed 1 year ago

RTimothyEdwards commented 1 year ago 
    chip_io padframe(
        // Package Pins
`ifdef USE_POWER_PINS
        .VDD    (VDD),          // Common padframe/ESD supply
        .VSS    (VSS),          // Common digital ground
        .gpio_pu_select_core(VSS),
        .gpio_pd_select_core(VSS),
        .gpio_schmitt_select_core(VSS),
        .gpio_slew_select_core(VSS),
`endif

(1) Signal pins should never be put inside a USE_POWER_PINS block (2) Signals should never be connected directly to power supplies

This needs either a constant-value output from the SoC, or (preferably) add four bits to the GPIO control register in the SoC core to drive these four signals.

mo-hosni commented 1 year ago

@RTimothyEdwards I fixed that in the PnR branch that I am working on and added the connection to the layout. Check this commit. https://github.com/efabless/caravel-gf180mcu/commit/6ab794ee3a678e2bd5fedf95d57673be5f4571bd