efabless / caravel

Caravel is a standard SoC harness with on chip resources to control and read/write operations from a user-dedicated space.
https://caravel-harness.readthedocs.io/
Apache License 2.0
278 stars 65 forks source link

Missing wire declarations at top level #169

Open RTimothyEdwards opened 1 year ago

RTimothyEdwards commented 1 year ago

Missing wire declarations at the caravel and caravan module top level verilog prevent running simulations with a setting of default_nettype none. I do not recommend a merge until I finish a check if all occurrences of default_nettype wire can be removed from the code without causing errors.

kareefardi commented 1 year ago

I think this might be helpful. These are the reported nets by yosys.

caravel.v:436: Warning: Identifier `\qspi_enabled' is implicitly declared.
caravel.v:437: Warning: Identifier `\uart_enabled' is implicitly declared.
caravel.v:438: Warning: Identifier `\spi_enabled' is implicitly declared.
caravel.v:439: Warning: Identifier `\debug_mode' is implicitly declared.
caravel.v:443: Warning: Identifier `\ser_tx' is implicitly declared.
caravel.v:444: Warning: Identifier `\ser_rx' is implicitly declared.
caravel.v:446: Warning: Identifier `\spi_sdi' is implicitly declared.
caravel.v:447: Warning: Identifier `\spi_csb' is implicitly declared.
caravel.v:448: Warning: Identifier `\spi_sck' is implicitly declared.
caravel.v:449: Warning: Identifier `\spi_sdo' is implicitly declared.
caravel.v:450: Warning: Identifier `\spi_sdoenb' is implicitly declared.
caravel.v:452: Warning: Identifier `\debug_in' is implicitly declared.
caravel.v:453: Warning: Identifier `\debug_out' is implicitly declared.
caravel.v:454: Warning: Identifier `\debug_oeb' is implicitly declared.
caravel.v:470: Warning: Identifier `\trap' is implicitly declared.
caravel.v:631: Warning: Identifier `\ext_clk_sel' is implicitly declared.
caravel.v:633: Warning: Identifier `\pll_clk' is implicitly declared.
caravel.v:634: Warning: Identifier `\pll_clk90' is implicitly declared.
caravel.v:638: Warning: Identifier `\ext_reset' is implicitly declared.
caravel.v:652: Warning: Identifier `\spi_pll_ena' is implicitly declared.
caravel.v:656: Warning: Identifier `\spi_pll_dco_ena' is implicitly declared.