search

efabless / caravel

Caravel is a standard SoC harness with on chip resources to control and read/write operations from a user-dedicated space.
https://caravel-harness.readthedocs.io/
Apache License 2.0
296 stars 69 forks source link

old layouts for defaults used in final layout #522

Open jeffdi opened 10 months ago

RTimothyEdwards commented 10 months ago

Ultimately comes down to line 242 of scripts/gen_gpio_defaults.py:

        if not os.path.isfile(mag_file):

This line can be removed, but I think it may be better to add a warning before overwriting files, or let the script fail.

        if os.path.isfile(mag_file):
            print('Warning:  Existing file ' + mag_file + ' exists and will be overwritten.')
            os.remove(mag_file)

        if not os.path.isfile(mag_file):
            ...
d-m-bailey commented 9 months ago

102 should fix this.

DavidRLindley commented 7 months ago

We think this is solved but not verified. The LVS check we are implementing should catch this issue. We can close when the LVS issue closes.