efabless / caravel_mgmt_soc_litex

https://caravel-mgmt-soc-litex.readthedocs.io/en/latest/
Apache License 2.0
25 stars 15 forks source link

Cocotb APIs and netlist #131

Closed M0stafaRady closed 8 months ago

M0stafaRady commented 10 months ago
  1. Update C APIs to clear interrupt when disable an interrupt
  2. Remove caravel_core from gate level netlist as the user should get it after running gen_gpio_defaults and include it in the user includes.
marwaneltoukhy commented 9 months ago
  1. Is it documented that the user needs to run gen_gpio_defaults script?
  2. Shouldn't the caravel_core be included in the user's includes?
  3. I think you can run the gen_gpio_defaults script as part of the verification make target for gl
M0stafaRady commented 9 months ago
  1. Is it documented that the user needs to run gen_gpio_defaults script?

I'm not aware if it is documented somewhere.

  1. Shouldn't the caravel_core be included in the user's includes?

Yes, That's true. That's why the PR remove them from caravel netlist

  1. I think you can run the gen_gpio_defaults script as part of the verification make target for gl Maybe, this a good idea.

This PR also contains some changes related to the APIs which needed to be merged.

marwaneltoukhy commented 9 months ago

It needs to be documented that in order to run the gl verification the users need to run gen_gpio_defaults, and you can add running the script in the Make target in order to run it automatically when a user runs the gl verification.

M0stafaRady commented 9 months ago

Documentation added here : https://github.com/efabless/caravel_user_project/pull/309