Different definitions at caravel.h and defs.h

efabless / caravel_mgmt_soc_litex

https://caravel-mgmt-soc-litex.readthedocs.io/en/latest/

Apache License 2.0

25 stars 15 forks source link

Different definitions at caravel.h and defs.h #52

Closed M0stafaRady closed 1 year ago

M0stafaRady commented 1 year ago

Caravel.h and defs.h have different declaration for GPIO_MODE* definitions. I tried the GPIO_MODE_MGMT_STD_INPUT_PULLDOWNand GPIO_MODE_MGMT_STD_INPUT_PULLUPin both and the one in caravel.h seems to be correct as the other one don't even configure them as inputs. Also register reg_wb_enableis declared 2 times with different values.

M0stafaRady commented 1 year ago

Also configuring the gpio as pull up or pull down don't seem to work I can see X's over housekeeping.mgmt_gpio_in signal when not diving

RTimothyEdwards commented 1 year ago

This has been fixed (needs to reference a pull request)

jeffdi commented 1 year ago

Fixed in ae92b99c17c4014daeff3021656ec19fecacb1e6