search

efabless / caravel_user_project_analog

Apache License 2.0
43 stars 90 forks source link

make update_caravel fails #28

Open buzmeg opened 1 year ago

buzmeg commented 1 year ago 
cd /home/foo/efabless/caravel_user_project_analog/caravel/ && git checkout mpw-7a && git pull
HEAD is now at de98d51 Modified the set_user_id.py script so that mode "-report" returns a valid value. (#93)
You are not currently on a branch.
Please specify which branch you want to merge with.
See git-pull(1) for details.

    git pull <remote> <branch>

make: *** [Makefile:92: update_caravel] Error 1
d-m-bailey commented 1 year ago

This is called because the current tag is a detached HEAD and not on a branch.

Fixed with PR #30

d-m-bailey commented 1 year ago

@SaraEfabless This will be fixed with PR #30

Probably want to do the same thing with caravel_user_project. Should I create a PR there, too?

SaraEfabless commented 1 year ago

Hi Mitch, Thanks for your fast response! No, I don’t think if it needs another PR. I’m going to close this ticket with adding comments.

Sara

On Oct 31, 2022, at 5:35 PM, Mitch Bailey @.***> wrote:

 @SaraEfabless This will be fixed with PR #30

Probably want to do the same thing with caravel_user_project. Should I create a PR there, too?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

d-m-bailey commented 1 year ago

@SaraEfabless I think the the pull request should be merged before this issue is closed.