efabless / openlane2

The next generation of OpenLane, rewritten from scratch with a modular architecture
https://openlane2.readthedocs.io/
Apache License 2.0
168 stars 30 forks source link

Multi-corner STA Pre-PnR #448

Closed donn closed 2 months ago

donn commented 2 months ago

Misc


Resolves #447

openlane-bot commented 2 months ago

Metric comparisons are in beta. Please report bugs under the issues tab.

To create this report yourself, grab the metrics artifact from the CI run, extract them, and invoke python3 -m openlane.common.metrics compare-main <path to directory>.

Full tables ► https://gist.github.com/openlane-bot/3c7b4e5cab6d45b9e5746c4c777426de

kareefardi commented 2 months ago
  • OpenROAD.STAPrePnR

    • Now performs multicorner STA pre-PnR according to STA_CORNERS; although if two corners have identical file lists the latter corner is skipped
    • Internally rearranged class structure so STA pre and post PnR share as much code as possible

Misc

* `openlane.steps`

  * `Step`

    * `.start()` no longer prints logs at the beginning as it may not necessarily exist
    * `.run_subprocess()` now prints the log path at log level `DEBUG`

Resolves #447

donn commented 2 months ago

Why the change from verbose to debug in the log path print?

Bit of a tendency to clog up the terminal, especially for steps and flows that use multithreading

kareefardi commented 2 months ago

Why the change from verbose to debug in the log path print?

Bit of a tendency to clog up the terminal, especially for steps and flows that use multithreading

Debug clogs up the terminal even more and having the clickables of the log files is more useful than running with log level debug