efabless / sky130_klayout_pdk

Skywaters 130nm Klayout PDK
Apache License 2.0
15 stars 10 forks source link

Move XML declaration to start of file for sky130.lym #14

Closed mole99 closed 2 months ago

mole99 commented 3 months ago

Moves the XML declaration to the beginning of the file to make it valid.

Similar to #12, but it seems this file has been forgotten as it is not read when using OpenLane.

RTimothyEdwards commented 2 months ago

@donn : I want to merge this but I also want to know why there are 35 failing regression test checks and why they are occurring.

mole99 commented 2 months ago

That would be good to know indeed! The CI is from Mabrains, so maybe Amro Tork knows more. We can open an issue about it and merge this PR in the meantime, since it does not affect the CI.

mole99 commented 2 months ago

Opened: #16

donn commented 2 months ago

Hi, I'm on vacation- I had nothing to do with this CI, so. All I did to this repo is move the XML headers to the beginning of the documents so later versions of KLayout stopped crashing.