pymacros module import error: gdsfactory.types is missing

efabless / sky130_klayout_pdk

Skywaters 130nm Klayout PDK

Apache License 2.0

14 stars 10 forks source link

pymacros module import error: gdsfactory.types is missing #20

Open martinjankoehler opened 3 weeks ago

martinjankoehler commented 3 weeks ago

Expected Behavior

sky130_tech/tech/sky130/pymacros/sky130.lym macro to properly load on klayout startup with technology installed.

Actual Behavior

Python module import error:

Steps to Reproduce the Problem

Update gdsfactory to a recent version pip install --upgrade gdsfactory
Start klayout, install the sky130 technology
Start again, the import error is reported

Specifications

Volare PDK Version: ├── PRE-RELEASE 31f6da2663f392b7472bdba39c1746170d293290 (2024.05.25) (enabled)
Platform: MacOS 10.14 and Ubuntu
Python: 3.12.3
gdsfactory 7.27.0
klayout: 0.29.1

martinjankoehler commented 3 weeks ago

With this Feature Branch the problem is fixed: https://github.com/martinjankoehler/sky130_klayout_pdk/tree/gdsfactory-types-fix

mole99 commented 2 weeks ago

Hi @martinjankoehler, thanks for the report and a potential fix!

Unfortunately, I am not sure that this works for the PCells. Last time I had a look at this, the changes allowed to load the pymacros, but the PCells failed to generate.

For now I have tried to pin gdsfactory and pydantic to an older version as seen here: https://codeberg.org/mole99/klayout-sky130-inverter But that should at least be documented, and in the best case the PCells should be fixed to work with the latest gdsfactory version. TBD!

martinjankoehler commented 1 day ago

Hi @mole99,

the branch is now updated, merged additional fixes and refactorings from @klayoutmatthias PR https://github.com/martinjankoehler/sky130_klayout_pdk/pull/1

mole99 commented 1 day ago

That's great @martinjankoehler!

Can you open a PR against this repo, so we can merge it here too? Thanks!

martinjankoehler commented 1 day ago

@mole99 done, see PR #21