search

efabrica-team / phpstan-latte

PHPStan extension to check compiled latte templates
MIT License
43 stars 4 forks source link

Replace FileAnalyser with PHPStan exec + output parsing for analysing of compiled tempaltes #159

Closed MartinMystikJonas closed 1 year ago

lulco commented 1 year ago

To be honest, I don’t see the reason of this step. Analysis working as is. The problem was only with collecting data

MartinMystikJonas commented 1 year ago

Also I figured out that there would be some significant complications with this (we would need to detect and pass all original parameters). It was recommended by Ondrej to avoid potential BC breaks with FileAnalyser, but I think we can let this to be an issue after some significant BC break hits us.

lulco commented 1 year ago

Agree. We always can try to rewrite it using some internal methods. And if it will not be possible once, than we can call phpstan with exec.

can we close it?

MartinMystikJonas commented 1 year ago

Close it