Add gatheringTimeoutAfterHost option

eface2face / rtcninja.js

WebRTC library to make media management easier across different browsers.

MIT License

73 stars 23 forks source link

Add gatheringTimeoutAfterHost option #23

Open Rob--W opened 9 years ago

Rob--W commented 9 years ago

Add "gatheringTimeoutAfterHost" option. The existing gatheringTimeout option serves a similar purpose, with a subtle distinction:

gatheringTimeout forces ICE gathering to stop after a fixed amount of time, even if no candidates have been found.
gatheringTimeoutAfterHost waits until at least one host candidate has been found before starting the timer.

The timer logic was spread all over the place, I also deduplicated the logic and put the relevant logic in two helper functions.

Rob--W commented 8 years ago

@ibc Could you review and merge this PR?

ibc commented 8 years ago

Sorry for the late response.

Honestly, I think we should avoid custom API. Both gatheringTimeout and gatheringTimeoutAfterRealy provide a temporal workaround for non trickle-ICE users, but I don't feel comfortable having them.

Rob--W commented 8 years ago

@ibc Done, thanks for the review!