Closed dangowrt closed 3 months ago
Thanks for the test case. I hadn't seen one with initramfs
in the images before, most of the "bad" types had no filesystem
value specified in the image block.
Got a fix that does this, will push in a few minutes.
$ owut check --device mvebu/cortexa72:iei,puzzle-m902
Target mvebu/cortexa72
Profile iei_puzzle-m902
Root-FS-type squashfs
Sys-type sdcard
Package-arch aarch64_cortex-a72
Version-from SNAPSHOT r26741-dcc4307205 (kernel 6.6.34)
Version-to SNAPSHOT r27041-7686ce4a91 (kernel 6.6.43)
Build-FS-type squashfs
Build-at 2024-07-29T08:32:57Z
Image-prefix openwrt-mvebu-cortexa72-iei_puzzle-m902
Image-URL https://downloads.openwrt.org/snapshots/targets/mvebu/cortexa72
Image-file openwrt-mvebu-cortexa72-iei_puzzle-m902-squashfs-sdcard.img.gz
$ owut check --device mvebu/cortexa72:iei,puzzle-m902 -F ext4
Target mvebu/cortexa72
Profile iei_puzzle-m902
Root-FS-type squashfs
Sys-type sdcard
Package-arch aarch64_cortex-a72
Version-from SNAPSHOT r26741-dcc4307205 (kernel 6.6.34)
Version-to SNAPSHOT r27041-7686ce4a91 (kernel 6.6.43)
Build-FS-type ext4
Build-at 2024-07-29T08:32:57Z
Image-prefix openwrt-mvebu-cortexa72-iei_puzzle-m902
Image-URL https://downloads.openwrt.org/snapshots/targets/mvebu/cortexa72
Image-file openwrt-mvebu-cortexa72-iei_puzzle-m902-ext4-sdcard.img.gz
$ owut check --device mvebu/cortexa72:iei,puzzle-m902 -F jffs2
ERROR: File system type 'jffs2' should be one of [ "ext4", "squashfs" ]
owut
should consider only image types with matching filesystem. Currently this doesn't work and leads to breakage of the image selection heuristic:So image type
kernel
should not even be considered because it is of fstypeinitramfs
while we should only considersquashfs
images to begin with.