search

efcore / EFCore.NamingConventions

Entity Framework Core plugin to apply naming conventions to table and column names (e.g. snake_case)
Apache License 2.0
738 stars 74 forks source link

Update to .NET 7.0 #163

Closed buvinghausen closed 2 years ago

buvinghausen commented 2 years ago

@roji with the advent of RC1 dropping with the go-live license we need to update the dependencies here too.

Let me know if I missed anything.

roji commented 2 years ago

@buvinghausen thanks for looking at this - can you confirm that all tests are green when run locally?

Note that EF 7.0 targets the net6.0 TFM, so there's no need to change the TFM of this library (that's also what causes the build failure in CI).

buvinghausen commented 2 years ago

@roji I changed the tfm on the main library to net6.0 the Test project requires .NET 7.0 because of the Microsoft.EntityFrameworkCore.Specification.Tests dependency.

There are two failing tests which I will look into now.

Table_splitting_and_explicit_owner_table & Table_splitting1 both are rendering Split2_common and expect split2_common

buvinghausen commented 2 years ago

@roji I think the bug is upstream in EF because the rewrite name function only ever returns split2 when debugged in the tests. Unfortunately I don't have time to keep digging deeper we don't use objects with the same property name in the same table so this doesn't impact us so for the time being I'm just using the fork I created to get us moving forwards. If/when there is a 7.0 compatible release I will flip back over.

Thanks

roji commented 2 years ago

Thanks for looking into it; at some point I'll find the time to release a 7.0-compatible version. I doubt there's a bug upstream, but the conventions can be extremely tricky to figure out here, following past experience.