search

efcore / EFCore.NamingConventions

Entity Framework Core plugin to apply naming conventions to table and column names (e.g. snake_case)
Apache License 2.0
759 stars 75 forks source link

Upgrade to .NET 9 and entity framework 9 #297

Closed phenixdotnet closed 1 week ago

phenixdotnet commented 1 week ago

Hi.

Not sure how you handle major version upgrade but if it can help you will find here a PR bumping .NET & entity framework version to 9.

No code change seem to be required and unit tests pass

ErikEJ commented 1 week ago

.NET version should stay at 8.0

phenixdotnet commented 1 week ago

Hello @ErikEJ

The package Microsoft.EntityFrameworkCore.Specification.Tests isn't compatible with .NET 8 so what do you prefere :

Also I upgrade the major version of the project to 9.0.0 as changing the .NET version is a IMO a breaking change but if the .NET version is kept to .NET 8 is that still revelant ?

ajcvickers commented 1 week ago

@phenixdotnet Build against 8; test against 9.

phenixdotnet commented 1 week ago

done :)

attilah commented 1 week ago

Please push the button @ErikEJ or @MirolimMajidov :) Thx for the PR @phenixdotnet!

roji commented 1 week ago

@attilah just to set expectations, I'm probably going to want to do a pass over pending issues and generally make sure everything looks good - actually publishing this plugin will take a bit more time.

roji commented 1 week ago

FYI the build is failing since the Github Actions workflow is still using dotnet SDK 8. Will push a fix.

attilah commented 1 week ago

@roji understood, it is just a blocker for upgrading to .NET 9.0 as 8.0.3 has a <9.0 constraint on the ef core dependency, will monitor and upgrade once it is release!