efdevcon / pretix-attestation-placeholder-plugin

Pretix plugin to support placeholders for attestations
MIT License
2 stars 7 forks source link

configuration PEM file cannot be saved #24

Closed kvbik closed 3 years ago

kvbik commented 3 years ago

The configuration PEM file is being saved somewhere next to the python code [1], which may work just in development. In production the code directories are usually write-protected.

[1] https://github.com/efdevcon/pretix-attestation-placeholder-plugin/blob/main/pretix_attestation_plugin/views.py#L10

Also Django file uploads are handled [2] in quite specific way - can be configured via backends, stored in a different locations, etc. And this must be followed.

[2] https://docs.djangoproject.com/en/3.2/topics/http/file-uploads/

Another way of doing this would be saving the content directly to database as a TextField.

kvbik commented 3 years ago

This was resolved in #25 - thx.