search

efdevcon / pretix-attestation-placeholder-plugin

Pretix plugin to support placeholders for attestations
MIT License
2 stars 7 forks source link

Use settings value instead of BaseURL model #30

Closed kvbik closed 3 years ago

kvbik commented 3 years ago

There is a DB value specific for this plugin called BaseURL. If it is just the URL where the Pretix instance is running, this value should be define in Django settings (from django.conf import settings) and is called settings.SITE_URL.

ligi commented 3 years ago

no - it could be a different site - so IMHO this is correct so - the attestation site will most likely not be part of the pretix instance but part of the website.

kvbik commented 3 years ago

Gotcha @ligi - It crossed my mind this can be the way it works. Thank you - closing!