search

efdevcon / pretix-eth-payment-plugin

An etheruem payment provider plugin for pretix
Other
42 stars 21 forks source link

Add L2 networks - basic #151

Closed rahul-kothari closed 3 years ago

rahul-kothari commented 3 years ago

Note- Still need to add styling and tests

What was wrong?

How was it fixed?

Cute Animal Picture

![Cute animal picture]()

kvbik commented 3 years ago

Cannot create issues in the original reporitory, so here you are:

The payemnt.Ethereum.is_allowed() can bite you pretty hard - it needs to be documented what are the all things you need to setup to make the plugin work:

Ideally it should not fail 500 Internal Server Error when the configs are not in place. You should do at least something like json.loads(settings.get( 'VALUE', default='{}'))... one piece of inspiration is the pretix code itself https://github.com/pretix/pretix/blob/master/src/pretix/base/payment.py#L162

rahul-kothari commented 3 years ago

@kvbik good idea - done!

rahul-kothari commented 3 years ago

Amongst others we can close 3 issues:

https://github.com/esPass/pretix-eth-payment-plugin/issues/53 https://github.com/esPass/pretix-eth-payment-plugin/issues/7 https://github.com/esPass/pretix-eth-payment-plugin/issues/5