efe-osa / shape-generator

1 stars 0 forks source link

Frontend Challenge Feedback #1

Open cozzbie opened 4 years ago

cozzbie commented 4 years ago

Hi and thank you for showing an interest in joining us, here is our quick feedback.

Your project looked nice, had a nice way to update already created shapes, used docker, had working tests, did well with input handling and persisted shapes well. However, a lot was left to be desired in the areas of your documentation in your Readme, lacked a way to delete shapes and it was not responsive. Normally because of these lapses we would be halting things here however, your pros far outweighed your cons and in addition we noticed you are fullstack developer and would love to offer you a tryout for our backend role since this challenge has covered your frontend skills.

If this sits well with you, here is our Technical Interview Invite Link and we hope to see you soon

Regards.

efe-osa commented 4 years ago

Thank you for the feedback and the critic. I agree the documentation could have been done better as well as the responsiveness of the layout. Also, the ability to delete shapes was made available but was specific to the delete keyboard event like on Figma.

I am absolutely interested in the opportunity for the backend role and I'm looking forward to our future conversation. Thank you once again.