efefefefefefefefefef / cfg-loader-mod

Automatically exported from code.google.com/p/cfg-loader-mod
GNU General Public License v2.0
0 stars 0 forks source link

Cheat download fix review #150

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
The r78 patch by pabloacurielz works for geckocodes but simply removes referer 
from the downloadfile_fname() function. Referer sometime is used by sites to 
allow the access of the contents. I think is better to leave the referer in 
downloadfile_fname() and add a downloadfile_noreferer_fname() function and it's 
wrapper downloadfile_noreferer(), then in cheats.c call the "noreferer". This 
allow the cheats download from geckocodes but allow also the use of referer if 
needed in the other calls.
This is still a quick and dirty patch, the best way is adding a parameter to 
the original cople downloadfile() / downloadfile_fname() but such change in the 
http functions interface implies a review of the entire source code to fix 
every call. I think is better to leave the referer for other downloads than 
geckocodes.

Original issue reported on code.google.com by nitrai...@gmail.com on 27 Nov 2014 at 8:56

Attachments: