search

effectai / effect-network

Smart contracts and documentation for Effect Network
MIT License
46 stars 9 forks source link

Can not create batches for campaigns with 0 EFX reward #114

Open jeisses opened 1 year ago

jeisses commented 1 year ago

Feature

It should be possible to create campaign with 0 rewards.

At the moment this is not possible (there is a silent failure in the UI, with an error printed to the console related to "transfer positive quantity)"

This is most likely because the smart contract tries to send a 10% fee (which amounts to 0). The fee should be skipped for free campaigns.

jeisses commented 1 year ago

I published a fix at https://github.com/effectai/effect-network/commit/e8d1f03ec367639e63c2eb043d9d08aa869a02eb