effector / effector

Business logic with ease ☄️
https://effector.dev
MIT License
4.58k stars 233 forks source link

Deprecate `Domain` unit creator methods #1051

Open kireevmp opened 6 months ago

kireevmp commented 6 months ago

As discussed in #590, methods on Domain are hard to work with within plugins (both Babel and SWC).

Proposal

Deprecate the following legacy Unit creators on Domain:

There has been an alternative way to attach the domain to a unit via argument since Encke 22.4.0 (released Nov 5, 2022), so there's been enough time to adopt it.

Additionally, Domain methods provide worse DX by default and are inconsistent with the rest of Effector API.

zerobias commented 4 months ago

Yes, it’s a good idea, we’ll go in that direction, maybe we could deprecate them altogether.

Next major version should be relatively small, without large depreciations, so it’s planned for the effector 25