effectussoftware / react-custom-roulette

Repository for the react-custom-roulette library
MIT License
322 stars 114 forks source link

Incompatibility with ReactJS 18.x.x #75

Closed JosePascual closed 1 year ago

JosePascual commented 2 years ago

When I proceeded to install react-custom-roulette in a React 18.0.1 project it gave me incompatibility.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: project-name@0.1.0
npm ERR! Found: react@18.1.0
npm ERR! node_modules/react
npm ERR!   react@"18.1.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.13.1" from react-custom-roulette@1.2.0
npm ERR! node_modules/react-custom-roulette
npm ERR!   react-custom-roulette@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
wilhelmuggla commented 2 years ago

I had the same issue. Use --force when installing with npm

s-gbz commented 2 years ago

I'm interested in that too! Not sure how great it is to use --legacy-peer-deps or --force.

nash90 commented 2 years ago

It works but the app build is too slow and bundle is too large due to inclusion of react 16 just for the sake of the lib

Acarvajal904 commented 1 year ago

Roulette now support React 18.x.x thank you for your comments