effekseer / Effekseer

MIT License
1.49k stars 219 forks source link

Editor/Viewer doesn't support material version 1.8 (produced by MaterialEditor) #1014

Open glebov-andrey opened 5 months ago

glebov-andrey commented 5 months ago

Hi, there is an issue in the master branch when trying to edit a material in MaterialEditor.

As soon as MaterialEditor loads the material, it resaves it in IPC for Viewer but uses the newer version 1.8 instead of 1.7. When Viewer tries to load it from IPC, the material appears broken without any visible error message or log. I've tracked it to this check which supports version 1.7, but not 1.8: https://github.com/effekseer/Effekseer/blob/ab18c95e297f60eb2c69a5750a36faa2ca06a8fd/Dev/Cpp/Effekseer/Effekseer/Material/Effekseer.MaterialFile.cpp#L31-L34

I understand that 1.8 is still in development - is this behavior expected at the moment?

durswd commented 5 months ago

I need to fix

durswd commented 4 months ago

https://github.com/effekseer/Effekseer/commit/8619dc1fe388e67ffa25651453c22aa89804d57f

I fixed it