Release not called in proper instance

effekseer / EffekseerForCocos2d-x

MIT License

42 stars 18 forks source link

Open sp-rafael-lecina opened 4 years ago

sp-rafael-lecina commented 4 years ago

When trying to change the effect on an emmiter I've found that release is not called in proper variable https://github.com/effekseer/EffekseerForCocos2d-x/blob/6dc954749da2aded607fcc8c1133e58763f91c49/Players/Cocos2d-x_v3/Effekseer.cpp#L706 That line should be if (this->effect != nullptr) this->effect->release(); Otherwise you are releasing the effect you are trying to set

durswd commented 4 years ago

It is bug. Thank you for your report. I will fix it

durswd commented 4 years ago

I fixed

sp-rafael-lecina commented 4 years ago

Thanks!