search

effekseer / EffekseerForCocos2d-x

MIT License
41 stars 18 forks source link

Infinite recursion if effect is played with an offset #9

Open sp-rafael-lecina opened 4 years ago

sp-rafael-lecina commented 4 years ago

If an effect is played starting on a frame different that 0 ManagerImplemented::Preupdate is called recursivelly infinitely The issue is that the flag: https://github.com/effekseer/EffekseerForCocos2d-x/blob/6dc954749da2aded607fcc8c1133e58763f91c49/Players/Cocos2d-x_v3/EffekseerNative.cpp#L16347 Should be set before the for loop Otherwise the condition in https://github.com/effekseer/EffekseerForCocos2d-x/blob/6dc954749da2aded607fcc8c1133e58763f91c49/Players/Cocos2d-x_v3/EffekseerNative.cpp#L16315 is always false and ManagerImplemented::Preupdate is called again

durswd commented 4 years ago

Thank you. I will check and fix it

durswd commented 4 years ago

I fixed

sp-rafael-lecina commented 4 years ago

Thanks!