effekseer / EffekseerForWebGL

MIT License
116 stars 17 forks source link

Fix type of 'data' parameter of loadEffect to allow ArrayBuffer #107

Closed mrxz closed 1 year ago

mrxz commented 1 year ago

The loadEffect function allows either a URL (string) or an ArrayBuffer, but the types in effekseer.d.ts only allowed string. This PR updates the type to allow either, matching the JavaScript code.

The naming and comments also weren't quite in sync between the two, one naming it data while the other calling it path. Updated the code to consistently use data in this case as it might not be a path. Functionality has been left unchanged.

durswd commented 1 year ago

Thank you!