effekt-lang / effekt-website

Website of the Effekt programming language
https://effekt-lang.github.io/effekt-website
MIT License
4 stars 6 forks source link

Getting Started page has a wrong permalink #78

Open CanCodes opened 1 month ago

CanCodes commented 1 month ago

The getting-started.md file has it's permalink set to docs, resulting in some redirection issues: https://github.com/effekt-lang/effekt-website/blob/3cab20ab405e7cd38aa9c73e3f50587694693878/index.md?plain=1#L51

https://github.com/effekt-lang/effekt-website/blob/3cab20ab405e7cd38aa9c73e3f50587694693878/quickstart.md?plain=1#L9

https://github.com/effekt-lang/effekt-website/blob/3cab20ab405e7cd38aa9c73e3f50587694693878/_layouts/home.html#L49

These redirects all fail, resulting in a 404 page. Changing the permalink or the redirects should fix the issue.

jiribenes commented 1 month ago

Thanks for the nice issue, I can easily reproduce this! :)

jiribenes commented 2 weeks ago

The quick solution here is just to change the links to point to /docs, a more long-term one would be to also set-up a redirect from docs/getting-started to docs so that we don't hurt the poor search engines. :)

As far as I remember, a classic way to do that with Jekyll is putting something like:

{% if page.redirect %}<meta http-equiv="refresh" content="0; url={{ page.redirect }}">{% endif %}

into the header (or making a new layout for pages that should redirect).

If you're tackling this as a part of a "good first issue", feel free to only fix the links and then make a follow-up issue for the redirects. :)

b-studios commented 1 week ago

For the time being, I just changed the link in the Effekt README.md