Closed jiribenes closed 3 months ago
Ah you already discuss the prefixing in the PR description...
But many tools already prefix it, like javac
, git
, brew
, pdflatex
, ...
I'm also perfectly fine with somebody else going through the alternative solutions linked in the PR description, my requirements right now are:
effekt --version
really prints only the version, as it really makes everything much easier when working with external tools (VSCode, JS, /bin/sh, ...), andTo be more specific, I could see somebody implementing the prefixing, but than someone else needs to go ahead and handle this in all of the tooling.
I agree it is simpler to process, but you probably need to parse the version anyways, no? If not, then lexicographic ordering would also work for a stable prefix, still.
I am just saying: I know how to strip a prefix in javascript (version.replace("Effekt ", "")
), but don't know whether it is possible to configure Scallop the right way without forking it.
It complicates the tooling [IMO a bit unnecessarily], but I really need this PR to go through to unblock the other ones, so I'll concede the point and just do Effekt 0.1.2.3
instead (see the updated PR description).
Now the question is: are we happy with this format? It will be really difficult to change it afterwards, so please, if there's anybody who wants the output to look differently, now's your chance, please speak up!
You can also just go with the version number and I'll ask the Scallop developer to help us.
I don't have a strong preference so choose what you prefer and I'll handle the rest :)
I went ahead and customised all of the tooling so that it can handle a prefix, now I just want some confidence vote on the specific prefix to be used so that I don't have to support multiple different ones in the future.
... so, does anybody want a different format?
Resolves #540
Scallop already supports printing out a version just by calling
version(<your version identifier>)
(see docs here), let's just use it :)Usage
(I changed my version in
build.sbt
in order to make this very visible)Help page
The version also gets printed out on
--help
:Note that we could add a larger "Usage: effekt ..."-style banner, see here.