search

efficient / libcuckoo

A high-performance, concurrent hash table
Other
1.61k stars 275 forks source link

need more LIBCUCKOO_SQUELCH_PADDING_WARNING #131

Open grandinj opened 3 years ago

grandinj commented 3 years ago

hi

thanks for this awesome project!

with latest MSVC, warnings have moved around, and we need an extra warning suppress, like this:

bool &is_migrated() noexcept { return is_migrated_; }
bool is_migrated() const noexcept { return is_migrated_; }

private: std::atomicflag lock; counter_type elemcounter; bool ismigrated; LIBCUCKOO_SQUELCH_PADDING_WARNING };

manugoyal commented 3 years ago

Hi Noel, thanks for reporting! I don't have MSVC myself, so I can't verify too easily. But I would be happy to accept a pull request that suppresses these warnings.