search

efficientqa / efficientqa.github.io

MIT License
3 stars 1 forks source link

Docker image size #4

Open mksenzov opened 4 years ago

mksenzov commented 4 years ago

Page https://efficientqa.github.io/submit.html claims that to check image size you will use 

docker run "${MODEL}" du -h

Questions:

  1. This implies that anything outside of the workdir is not measured, so if my workdir is /app and I put data in / - that is not counted. Did you intend to say docker run "${MODEL}" du -h / instead?

  2. why not just use docker images output (SIZE column)?

Any clarification would be appreciated.

mksenzov commented 4 years ago

or should we perhaps, consider the size of the image as it is stored in Google Container Registry - it appears like GCR further compresses those and my local 6Gb image is shown 4.49 GB which indicate that I still might have a ton of space available.

tomkwiat commented 4 years ago

Hi Mikhail, we are using du -h / to get everything, yes. Sorry that wasn't clear, the instructions have been updated.

djshowtime commented 3 years ago

Hi Mikhail, we are using du -h / to get everything, yes. Sorry that wasn't clear, the instructions have been updated.

Does it mean that even the size of the system environment package also counted?

soheeyang commented 3 years ago

Hi @djshowtime , I'm just a participant in the challenge, but yes, everything in the docker container including the system environment package seems to be counted.