search

efficios / barectf

Generator of ANSI C tracers which output CTF data streams
https://barectf.org
MIT License
65 stars 17 forks source link

barectf: add support for packet sequence number #24

Closed jonlamb-gh closed 2 years ago

jonlamb-gh commented 2 years ago

Adds a new optional packet features object seq-num-field-type, which generates the metadata field type name packet_seq_num when defined (defaults to false). Currently this is conditionally maintained in struct barectf_ctx as a uint32_t type like events_discarded. In the future this could be improved to use the config type defined by the stream in struct barectf_default_ctx so that the types are aligned.

Closes #23

Signed-off-by: Jon Lamb jon@auxon.io

eepp commented 2 years ago

May I kindly ask you to submit this patch to barectf's Gerrit instead?

Review will be much more easier this way.

eepp commented 2 years ago

May I kindly ask you to submit this patch to barectf's Gerrit instead?

I can assist if you're not familiar.

jonlamb-gh commented 2 years ago

:+1: First time with Gerrit, but I think I got it: https://review.lttng.org/c/barectf/+/7496

eepp commented 2 years ago

First time with Gerrit, but I think I got it:

🥳 Thank you!

Closing this PR as I'll merge into master directly from Gerrit.