search

eficode-academy / git-katas

A set of exercises for deliberate Git Practice
MIT License
1.32k stars 860 forks source link

Remove --decorate from katas #178

Closed JKrag closed 5 years ago

JKrag commented 5 years ago

The --decorate option is default in git log, and provides no value in the form where it is currently used in the examples.

sofusalbertsen commented 5 years ago

Can't seem to find the documentation that says that decorate is default. Otherwise :+1:

RandomSort commented 5 years ago

https://github.com/git/git/commit/940a911f8ec00e291a66c2d1ed05293a38ae6138 :D

JKrag commented 5 years ago

@RandomSort That was the hardcore answer to @sofusalbertsen's question :-)

I would probably have posted:

$ git help log
....
       --no-decorate, --decorate[=short|full|auto|no]
           Print out the ref names of any commits that are shown. If short is
           specified, the ref name prefixes refs/heads/, refs/tags/ and
           refs/remotes/ will not be printed. If full is specified, the full
           ref name (including prefix) will be printed. If auto is specified,
           then if the output is going to a terminal, the ref names are shown
           as if short were given, otherwise no ref names are shown. *The
           default option is short.*

Doing that, however, it is worth noticing that the default is actually now short, even though the commit you linked to suggest auto in the headline (although the code/tests seems to collaborate short)

sofusalbertsen commented 5 years ago

<3 you two!