eficode-academy / git-katas

A set of exercises for deliberate Git Practice
MIT License
1.32k stars 860 forks source link

Improve wording of task in "Basic Commits" #228

Closed ghost closed 4 years ago

ghost commented 4 years ago

A trainee may not realize that the change made to the file needs to be added before committed.

sofusalbertsen commented 4 years ago

Hi @shifuchen98 , and thanks for your PR. Normally I would say that this is made deliberately to get people to think for themselves (add comes before a commit), but since this is one of the basic katas, I would tend to agree. Summon @RandomSort

RandomSort commented 4 years ago

I am with Sofus, but I think we have a tendency to being overly clever and set the student up to fail, rather than to prompt thinking. Thank you for your pull request!