search

eficode-academy / git-katas

A set of exercises for deliberate Git Practice
MIT License
1.32k stars 860 forks source link

Remove point 9 #313

Closed Dev-Puneet-V closed 2 years ago

Dev-Puneet-V commented 2 years ago

Here point 9 seems of no use, since before merging FEATURE and master branch, master branch will not contain greeting.txt file, so the output would be file not found whenever we will be on master branch and try to use cat greeting.txt.
Point to be removed:
9. Use cat to see the contents of the greetings

JKrag commented 2 years ago

@Puneet-iner I don't agree with this change. The greeting.txt file already exists on master when the exercise starts, and thus should also be there when you get to point 9. We are cat'ing the file at this point to show that it contains the lowercase version of "hello", not the uppercase "HELLO" that we have made on the feature/uppercase branch.

To be sure, I just ran through the exercise myself to double check. I have also used in in Git training 4 times in the past month without any comments from participants.

I don't think this PR should be merged. Let me know if you disagree.

Dev-Puneet-V commented 2 years ago

I agree with you. My confusion lead to this PR.