search

efrecon / docker-s3fs-client

Alpine-based s3fs client: mount from container, make available to other containers
BSD 3-Clause "New" or "Revised" License
173 stars 62 forks source link

GID must be specified when UID is specified #2

Closed totycro closed 3 years ago

totycro commented 4 years ago

Hi!

Thanks for providing this very convenient docker image!

I just noticed a minor issue: If you specify the UID, but not the GID, then the mount actually fails. The first problem is here, where adduser fails due to GID being 0, so you get adduser: unknown group 0: https://github.com/efrecon/docker-s3fs-client/blob/master/docker-entrypoint.sh#L48

Therefore the user is not created and the subsequent commands fail.

This is not really a bug, but it might be nice to e.g. get a more precise error message or set GID to some default value.

efrecon commented 3 years ago

You fixed it, it's merged! So I close this. Thanks again.