test_loader fails

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Run test_loader.py from git repository
2. testGraphEdges fails

Apparently, edge_result has three values in each item in the list, the last
one being None, whereas the expected result has only two.

I've included a patch in which the expected result matches edge_result. I
have also changed the import so it will import from pygr, instead of
relying on the pygr environment variable. Feel free to ignore this. 

Original issue reported on code.google.com by ramccre...@gmail.com on 11 May 2008 at 3:44

Attachments:

• test_loader.py.diff

[GoogleCodeExporter]

Also change the bottom to exit with a failure code when test suite fails:

   if not TestFrameWork().go():
      sys.exit(-1)

Original comment by the.good...@gmail.com on 11 May 2008 at 6:58

[GoogleCodeExporter]

I made the suggested changes. I have second thoughts about doing an absolute 
import
from pygr. Maybe it would be better to use a .pth file to allow redirection of 
import?

Original comment by ramccre...@gmail.com on 12 May 2008 at 4:14

Attachments:

• test_loader.py.diff

[GoogleCodeExporter]

Hi Rachel,
actually test_loader.py is one of the obsolete test suites left over from 
before we
migrated to nose-style tests.  The nose-style tests contain all the 
functionality
from the old tests (plus new tests), but follow the nose convention that all 
test
files are named in the form *_test.py.  The current, equivalent test is
graph_test.py:Mapping_Test.graphedges_test, which is part of the nightly test 
suite.  

To run the standard test suite (this is documented in detail in the Pygr Docs):
python protest.py

I apologize for the confusion -- actually we can blame it all on Titus!  He's 
the one
who told me to switch our tests to nose...  The old (deprecated) test files are 
still
in the package simply because under CVS it was a real pain in the @#$%@ to 
delete
files from the source code repository.  I suppose now that we're using git we 
should
just remove those old test files, or move them to a deprecated directory.

Titus, what do you think?

Original comment by cjlee...@gmail.com on 13 May 2008 at 9:22

[GoogleCodeExporter]

All the old (pre-nose) test scripts have been removed from the tests/ 
directory, so
this issue is resolved.

Original comment by cjlee...@gmail.com on 22 Aug 2008 at 8:23

• Changed state: Verified

[GoogleCodeExporter]

Original comment by mare...@gmail.com on 21 Feb 2009 at 1:27

• Changed state: Closed