minor refactoring of protest.py

[GoogleCodeExporter]

 2008 12:54:22 -0700
Subject: [PATCH] nolleyal and titus's minor refactoring of protest.py.

Briefly,

 - switched the os.system call to subprocess, which removes the need to
   use temporary files to store stdout;

 - added stderr capture & replay;

 - added #! /usr/bin/env python at the top to support 'protest.py's
   direct use from the shell;

 - added a docstring at the top of the file;

 - removed space from '.' output to conform to nose's output;

 - cleaned up the main test runner and a few other places for PEP-8.

NOTE that subprocess doesn't exist in Python 2.3, so this axes Python
2.3 compatibility for the tests.  I don't know how important this is, as
every major platform now comes with 2.4 or above; see mailist list
discussion.

Original issue reported on code.google.com by the.good...@gmail.com on 21 Jun 2008 at 8:55

Attachments:

• 0004-nolleyal-and-titus-s-minor-refactoring-of-protest.py.patch

[GoogleCodeExporter]

Original comment by the.good...@gmail.com on 22 Aug 2008 at 4:55

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by mare...@gmail.com on 21 Feb 2009 at 2:03

• Changed state: FixedNeedsReview

[GoogleCodeExporter]

Superseded by issue #65, Istvan's rewrite of the tests.

Original comment by the.good...@gmail.com on 1 Mar 2009 at 3:44

[GoogleCodeExporter]

Original comment by the.good...@gmail.com on 1 Mar 2009 at 3:44

• Changed state: WontFix