eftsung / pygr

Automatically exported from code.google.com/p/pygr
0 stars 0 forks source link

Unnecessary non-PEP-8 spacing in setup.py #25

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Too many inter-line spaces in setup.py!

Original issue reported on code.google.com by the.good...@gmail.com on 22 Aug 2008 at 5:00

GoogleCodeExporter commented 8 years ago
I think Titus fixed this.

Original comment by cjlee...@gmail.com on 11 Sep 2008 at 4:04

GoogleCodeExporter commented 8 years ago
I don't want to moan about coding standards when you're all doing such good 
work, but
since someone mentioned PEP8,  how about the too few blank lines everywhere 
else (eg
one line between methods as defined in the PEP)?  And the use of mixedCase and
lower_case_with_underscores in a single class?

Patches accepted?

Original comment by cas...@gmail.com on 15 Sep 2008 at 4:11

GoogleCodeExporter commented 8 years ago
No, I didn't fix it yet :).

casbon, I would review your patches as long as they were in places with ~80-90% 
test
coverage.  Less than that and you'll need to submit test patches with yours, 
which
would be fantastic but would also be a lot of extra work.

(It's not worth breaking the software to make it PEP-8 compliant :)

Original comment by the.good...@gmail.com on 20 Sep 2008 at 11:58

GoogleCodeExporter commented 8 years ago
Made obsolete by Istvan's setup.py change.

Original comment by the.good...@gmail.com on 11 Feb 2009 at 2:02

GoogleCodeExporter commented 8 years ago

Original comment by mare...@gmail.com on 21 Feb 2009 at 2:04

GoogleCodeExporter commented 8 years ago
See issue #67.

Original comment by the.good...@gmail.com on 1 Mar 2009 at 3:47