search

eftsung / pygr

Automatically exported from code.google.com/p/pygr
0 stars 0 forks source link

Test Istvan's new setup.py on multiple platforms #67

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
...and recommend for inclusion.

Original issue reported on code.google.com by the.good...@gmail.com on 11 Feb 2009 at 2:03

GoogleCodeExporter commented 8 years ago 
I isolated the changes from Istvan's PSU working version and fixed a problem 
with
Python2.6.  The attached patches work properly under Python 2.4, 2.5, and 2.6 on
Linux, as well as Python 2.5 on Mac OS X (default install).

This is an excellent set of changes that results in a major simplification of 
setup.py.

Note that Istvan's setup.py code does properly detect the lack of Pyrex and 
uses C
files, if they're available.

Istvan, if you could double-check everything on Windows I would appreciate it.  
At
the moment I don't have easy access.

Also, I suggest the inclusion of the following helper script somewhere, to help 
with
making builds:

## pyx-compile.sh
cd pygr
pyrexc cnestedlist.pyx 
pyrexc cdict.pyx
pyrexc seqfmt.pyx

Original comment by the.good...@gmail.com on 16 Feb 2009 at 10:41

Attachments:

GoogleCodeExporter commented 8 years ago 
Whoops, here's a patch set that correctly lists Istvan as the author on patch 
#2.

Original comment by the.good...@gmail.com on 16 Feb 2009 at 10:44

Attachments:

GoogleCodeExporter commented 8 years ago 

One line in setup.py is not needed, the one that added a library.zip file to 
pygr
package. I use that internally (on my projects) to add libraries that I might 
want to
make use of (like json or yaml parsing) without making it an explicit 
prerequisite. I
removed this line from from setup.py (see attached patch that merges both 
patches above).

An observation, to generate a version tuple I think you could use something as 
simple as:

ver = "%s.%s" % sys.version_info[:2]

rather than:

py_ver_tup = platform.python_version_tuple()
# NOTE: py_ver_tup contains ints in Python 2.6
py_ver_tup = [ str(x) for x in py_ver_tup[:2] ]
ver = ".".join(py_ver_tup)

but I have not tested it for all pythons, seems to work fine in 2.5 though.

Original comment by istvan.a...@gmail.com on 17 Feb 2009 at 3:34

Attachments:

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
all setup.py patches rolled into one

One behavior change, the default builder works like make, if the C file is 
younger
than the pxy file it will not re-run pyrex even if it is present. To force 
running
pyrex if it is present is to change the age of the generated C files to be 
older than
the pyx files.

Original comment by istvan.a...@gmail.com on 17 Feb 2009 at 4:18

Attachments:

GoogleCodeExporter commented 8 years ago 
Issue 63 has been merged into this issue.

Original comment by mare...@gmail.com on 17 Feb 2009 at 7:18

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago

Original comment by mare...@gmail.com on 21 Feb 2009 at 1:56

GoogleCodeExporter commented 8 years ago 
Note, long thread on the new setup.py here:

http://groups.google.com/group/pygr-dev/browse_thread/thread/6a87d53fbfe7deb2/bc
a6747a31330ea0

Nominated for inclusion; available on github under

http://github.com/ctb/pygr/tree/master

along with the new tests/ code (issue #65).

Original comment by the.good...@gmail.com on 1 Mar 2009 at 4:10

GoogleCodeExporter commented 8 years ago 
Whoops, actually, it's in a different branch from the new tests code: the 
'master'
branch contains setup.py changes, the 'psu-tests-branch' contains the tests 
code. 
Never mind.

Original comment by the.good...@gmail.com on 1 Mar 2009 at 4:14

GoogleCodeExporter commented 8 years ago 
Marek and I will review the new setup.py and related questions about updating 
all our
metadata and package config information properly.

Original comment by cjlee...@gmail.com on 5 Mar 2009 at 1:51

GoogleCodeExporter commented 8 years ago

Original comment by mare...@gmail.com on 13 Mar 2009 at 1:03

GoogleCodeExporter commented 8 years ago 
With the buildbot set up by Titus's students, my recent messing around with 
Windows 
and Chris working on Mac OS X, looks like this issue has sort of verified 
itself :-)
Closing.

Original comment by mare...@gmail.com on 8 Apr 2009 at 12:42