Support for sqlite

[GoogleCodeExporter]

sqlgraph has been extended to support databases other than MySQL; to begin
with, sqlite is tested and working.

All SQL tests have been replicated to test the sqlite3 platform separately
from the MySQL platform.

Original issue reported on code.google.com by cjlee...@gmail.com on 28 Feb 2009 at 3:50

[GoogleCodeExporter]

Titus and Jenny, could you do a sanity check on the sqlite support, before we 
close
this issue?  Istvan has reported that the sqlite tests passed on Windows, but of
course that only addresses what our test suite covers.  We can review this as 
part of
a code review of sqlgraph if you want.

Original comment by cjlee...@gmail.com on 5 Mar 2009 at 12:35

[GoogleCodeExporter]

In its present incarnation SQLite support only works with Python 2.5+, i.e. 
with 
versions which come with the sqlite3 module. For 2.3 and 2.4 the very same 
functionality is available via an external package, which however is not a 
drop-in 
replacement because the module's name was changed when this package was 
incorporated 
into the Python library (originally it was pysqlite2), and a slightly different 
import is required too (one needs to explicitly select DB-API 2.0 support).

Attached you will find a patch which attempts to address this issue: Pygr will 
now 
try to import pysqlite2.dbapi2 if sqlite3 import failed, with both modules 
being 
imported as 'sqlite' so that the same code works for both cases. I have tested 
this 
on the future new megatest machine (x86 running Linux, Python 2.4), all tests 
from 
the new framework pass. Please verify and include into master.

Original comment by mare...@gmail.com on 6 Mar 2009 at 9:24

Attachments:

• 0001-Try-to-use-pysqlite2-if-sqlite3-is-not-available-for.patch

[GoogleCodeExporter]

I refined your patch, added more sqlite tests (to sqlsequence_test.py), and 
pushed
all this to the public master.

Original comment by cjlee...@gmail.com on 6 Mar 2009 at 11:23

[GoogleCodeExporter]

Original comment by mare...@gmail.com on 13 Mar 2009 at 1:04

• Added labels: reviewby-the.good.doctor.is.in

[GoogleCodeExporter]

Looks good. We'll need to look at buildbot as well.

Original comment by istvan.a...@gmail.com on 14 May 2009 at 2:39

• Changed state: ReviewedNeedsCommit

[GoogleCodeExporter]

has been commited

Original comment by istvan.a...@gmail.com on 14 May 2009 at 12:37

• Changed state: Closed