search

eftsung / pygr

Automatically exported from code.google.com/p/pygr
0 stars 0 forks source link

pygr.downloader uses subprocess, which is not python2.3 compatible. #80

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
subprocess is used to unzip and gunzip downloaded files; this breaks under
python2.3, which doesn't have subprocess.

See metabase_test.

Original issue reported on code.google.com by the.good...@gmail.com on 28 Mar 2009 at 4:09

GoogleCodeExporter commented 8 years ago

Original comment by the.good...@gmail.com on 28 Mar 2009 at 4:36

GoogleCodeExporter commented 8 years ago 
1. Check subprocess import: If python raises ImportError (Python2.3), try using 
os.system().
2. Some lines with longer than 80 are reformatted.

Original comment by deepr...@gmail.com on 29 Mar 2009 at 12:25

Attachments:

GoogleCodeExporter commented 8 years ago 
Applied and fixed (missing 'import os'); on buildbot-fixes branch.

See thread:

http://groups.google.com/group/pygr-dev/browse_thread/thread/14c05a831eeb3ed7

Original comment by the.good...@gmail.com on 29 Mar 2009 at 9:35

GoogleCodeExporter commented 8 years ago 
I created a subprocess-like interface (FilePopen) that eliminates this issue, by
providing a consistent interface that works on Python 2.3 as well as with later
versions of Python.  For details, see
http://groups.google.com/group/pygr-dev/msg/e0b13465171a6d6d

Original comment by cjlee...@gmail.com on 8 Apr 2009 at 1:49

GoogleCodeExporter commented 8 years ago

Original comment by the.good...@gmail.com on 26 Apr 2009 at 8:48

GoogleCodeExporter commented 8 years ago 
Looks good, feels more complicated than it needs to be, but I don't want to 
volunteer
to simplify it.

Better PEP8 compliance, or at least an empty line above def declarations would 
help a
lot when looking at unfamiliar code.

Original comment by istvan.a...@gmail.com on 14 May 2009 at 2:37

GoogleCodeExporter commented 8 years ago 
The relevant code is now in the master.

Original comment by mare...@gmail.com on 5 Jun 2009 at 12:54