eg4000 / SKU110K_CVPR19

773 stars 183 forks source link

Suggestions for compatibility #79

Closed AlvaroCavalcante closed 4 years ago

AlvaroCavalcante commented 4 years ago

Hello, congrats on your awesome work. There are one day and a half that I'm trying to run the project fixing errors and environment versions. After some time, I created a virtual environment with the correct setup, this is my installed packages: image

Some suggestions that I think would help others would be:

These are my suggestions, let me know your opinion!

eg4000 commented 4 years ago

Hi,

Thanks a lot for your suggestions and for sharing the package list. We'll look into that.

Eran.

AlvaroCavalcante commented 4 years ago

Do you accept contributors? I could open a Pull Request with my suggestions once I'm using your project!

AlvaroCavalcante commented 4 years ago

@eg4000 Another problem I got was in the process to save annotations in CSV in the predict_iou.py file, the error was: "a bytes-like object is required, not 'str' write rows". To fix this I changed with open(res_file, 'wb') as fl_csv: to with open(res_file, 'w') as fl_csv:. This happens because of incompatibility errors between python 2 and 3. I think that standard your code to accept Python 3 (3.6.9 in my case) is important because this is the most used version nowadays.

eg4000 commented 4 years ago

The code was written in Python 2.7. I think some of it was converted to python 3 and opencv 4 here. Contributions are welcome. I'm currently quite busy so I'm not sure I'll have time to review and test code changes, but I'll really appreciate it if you provide a link to your repository when it is ready.

AlvaroCavalcante commented 4 years ago

@eg4000 No problem, I'll open a Pull Request with suggested changes and insights that I got while using your project ok? Test it when you or some of the other contributors have time. Can you add a label for Hacktoberfest in my PR, just to count in the event? I'll also attach this issue to the PR.

eg4000 commented 4 years ago

Added

eg4000 commented 4 years ago

80