search

egad1868 / prj-rev-bwfs-dasmoto

1 stars 0 forks source link

Overall Score #8

Open tommygebru opened 5 years ago

tommygebru commented 5 years ago

Overall Score

Criteria 1: HTML and CSS Linking
Score Level: 3 - HTML and CSS files contains some valid links to the correct file assets.

Criteria 2: Implementation of Design Specification and Content
Score Level: 4 - The page includes most styles and content provided in the design specification.

Criteria 3: HTML Elements and Content
Score Level: 3 - Content: HTML content matches the design specification
Tags: The tags in the HTML are used for their intended purpose.

Criteria 4: CSS Selectors and Syntax
Score Level: 4 - Syntax: Uses proper selectors (id, class, element type). All rule sets are valid CSS.

Overall Score:  14/16
tommygebru commented 5 years ago

Summary

Hey Amy, well done on your project Dasmoto, it's clear you have an excellent understanding of HTML and CSS basics. Spend a little more time reviewing/practicing upon the feedback until it clicks, and I'm confident you'll do fine.

Also keep some HTML/CSS best practices in mind when coding Quick review of Cascading Stylesheets or CSS and also A pretty neat html reference list When in doubt Google it (or MDN it) 🎉

tommygebru commented 5 years ago

Next Steps

You can update your project to include any of the suggestions I addressed today. Also if you choose to you can simply upload a new github repo, updated to reflect any feedback 👍

Ok Amy keep up the good work and happy coding!

egad1868 commented 5 years ago

Thank you for the thorough review! This is EXACTLY why I am here. I am 100% self-taught so far through the wonderful Google search and any books I can get my hands on and of course TONS of practice.