search

egaebel / lgtm

The code for my thesis project, Looks Good to Me (LGTM), Authentication for Augmented Reality. This is a full implementation of LGTM that localizes a wireless transmitter, and searches for a specific face at that location to authenticate two users trying to establish secure point to point communication.
57 stars 58 forks source link

packet_one_phase_matrix does not change in loops #8

Open yuehanlyu opened 6 years ago

yuehanlyu commented 6 years ago

Hi @egaebel. Thank you so much for sharing your code!

I have got a question in spotfi.m.

In line 61 you write packet_one_phase_matrix = unwrap(angle(csi), pi, 2); thus the packet_one_phase_matrix is assigned to be the unwrapped csi values of the first package.

In line 84 you write sanitized_csi = spotfi_algorithm_1(csi, sub_freq_delta, packet_one_phase_matrix); in the parfor loop. Thus the packet_one_phase_matrix is passed into spotfi_algorithm_1, which means the same packet_one_phase_matrix (that generated from the first package) is used for all packages.

Maybe I miss something, but I don't think this should be the case. Could you please explain a little bit?

yuehanlyu commented 6 years ago

Oh, are you using one linear fit that obtained from the first package for all the following packages to receive?

Challenger1132 commented 6 years ago

@yuehanlyu I also found this question that you are facing.

Zakieh commented 6 years ago

I am also having the same issue. Based on the code, the phases of CSI measurements for the first packet are used for all other packets which make absolutely no sense! At first, I thought they are just using the same linear fit for the other packets, but based on line 77 in apotfi_algorithm_1, they are actually using the same values and same tau for all other packets, not only the same tau! I would really appreciate if someone could help me with this problem. @egaebel

whubaichuan commented 6 years ago

@Zakieh @yuehanlyu @Challenger1132 Do you get over the problem now?

dasyma commented 5 years ago

I have the same problem. How did you solve it.

Zakieh commented 5 years ago

Sorry for the very late reply, I don't know how I missed these. Actually I think I couldn't get any good result out of the code and just gave up on it :/. Sorry that I can't be of more help.

whubaichuan commented 5 years ago

@Zakieh Thanks for reply. If you have any good result, please contact me. Have a good day.