Fix bytevector portability (failing tests on Android)

egallesio / STklos

STklos Scheme

http://stklos.net

GNU General Public License v2.0

69 stars 17 forks source link

Fix bytevector portability (failing tests on Android) #523

Closed jpellegrini closed 1 year ago

jpellegrini commented 1 year ago

Some (six) tests were failing on Android because we were trusting that the sign of char would be the same everywhere... So in Android, bytevector-sint-ref was not returning signed integers, as well as bytevector-s8-ref.

Changed several occurrences of char to int8_t. Passes all tests:

x86_64 GCC
x86_64 Clang
Android Clang (which was failing!)

(@egallesio - sorry the buggy code was mine... I should have been more careful.)

egallesio commented 1 year ago

Thanks @jpellgrini for the fix. Merging it.