egel / tmux-gruvbox

Gruvbox color scheme for Tmux.
GNU General Public License v3.0
503 stars 126 forks source link

Cannot install via tpm #15

Closed s-taylor closed 3 years ago

s-taylor commented 3 years ago

When I install this plugin via tpm the install seems to work, but I then get the error '~/.tmux/plugins/tpm/tpm' returned 1 when reloading shell and the theme doesn't load. I am on tmux 3.0a, so it might be a tmux issue but all my other plugins seem to work fine. I could potentially downgrade but just using what apt-get install provided.

egel commented 3 years ago

Thank you @s-taylor for this issue. I've seen this problem with the latest update also with tmux 3.1b. I will try to solve this as soon as I can. Any new PR with potential solution warm welcome 🙂

egel commented 3 years ago

Coping theme manually works fine, so the problem must be related only to the TPM configuration of the theme.

msbrigna commented 3 years ago

For me the problem is resolved with this fix #14

egel commented 3 years ago

Grande @msbrigna! 🙌 I can also confirm that this solved the problem for me (iTerm/macOS 10.15.7).

@s-taylor could you check #14 out, if this solves also the problem on your side? If true, I'd love to merge #14 🙂

egel commented 3 years ago

Additonally, I've noticed that the print is also causing the problem with ~/.tmux/plugins/tpm/tpm' returned 1 (iTerm/macOS 10.15.7).

Changing it, to echo solves the problem.

vignesh0025 commented 3 years ago

Additonally, I've noticed that the print is also causing the problem with ~/.tmux/plugins/tpm/tpm' returned 1 (iTerm/macOS 10.15.7).

Changing it, to echo solves the problem.

I had the same issue. Changing 'print' to 'echo' in get_theme() solved the issue.

egel commented 3 years ago

should be resolved by #14

s-taylor commented 3 years ago

Can confirm it's now fixed, thanks for your help 👍 Sorry about the delayed response.