egel / tmux-gruvbox

Gruvbox color scheme for Tmux.
GNU General Public License v3.0
521 stars 128 forks source link

WIP : compatibility with tmux 2.9 #7

Closed koalp closed 5 years ago

koalp commented 5 years ago

This is a work in progress pull request to update this theme to work with tmux 2.9

polyzen commented 5 years ago

https://github.com/tmux/tmux/wiki/FAQ#how-do-i-translate--fg--bg-and--attr-options-into--style-options

koalp commented 5 years ago

Thank you, but when I change to style none (like in my commit), i do not obtain the same result than in 1.8 . I still need to investigate to see how to obtain the wanted result.

In 1.8

tmux with tmux-gruvbox  in 1.8

In 1.9 without setting the none attributes

tmux with tmux-gruvbox patched on fg and bg only in 1.9

In 1.9 with the none attributes

tmux with tmux-gruvbox, trying to patch none in 1.9, but it doesn't work

koalp commented 5 years ago

I pushed a hacky workaround. It works but I don't really know why.

egel commented 5 years ago

I think I've managed to update the dark theme according to breaking changes in tmux v2.9. See this PR in #8.