search

egeland / nagios-rbl-check

Icinga/Nagios spam blacklist check, written in python
GNU General Public License v3.0
34 stars 18 forks source link

GitHub Actions #28

Closed smashedr closed 1 year ago

smashedr commented 1 year ago

Overview

Adds GitHub Actions to lint and test the script on push.

Test runs on all currently supported versions of Python, plus 3.5 (Version 2 is no longer supported on Actions).

Changes

.github/workflows/test.yaml

Test currently run under these conditions:

Test do the following:

check_rbl.py

README.md

.gitignore

setup.cfg

.travis.yml

smashedr commented 1 year ago

Note, the reason the workflows are not running right now is because they do not exist in the master branch of this repository yet. You can view the runs on my fork: https://github.com/smashedr/nagios-rbl-check/actions

These restrictions prevent duplicate workflow runs when a branch in the main repository with a pull request is pushed too. Basically, anything but PR's to master and pushes to master (merge commits in this case).

Also, this commit (and all commits via a restriction IMO) should be squash merged.

altmas5 commented 1 year ago

Yes, I agree, the commits should be squash merged and yes, I was able to see the runs on your fork.

smashedr commented 1 year ago

I assume everyone who wants to review this has had time. Going to merge this and verify CI is working. No actual code changes anyway. This will however make new changes much easier to test and implement.